Some change on getContainer

2022-12-08

@zombieJ

Tree's check conduction Component-level CSS-in-JS

// Fake Code. Just for Demo

const PopupWrapper = () => {

const eleRef = React.useRef<HTMLDivElement>(null);

React.useEffect(() => {

// It's much complex with timing in real world. You can view the source for more detail:

// https://github.com/react-component/portal/blob/master/src/Portal.tsx

const container: HTMLElement = getContainer(eleRef.current);

// ...

}, []);

return (

{...}

</div>

);

}

// Fake Code. Just for Demo

const defaultGetContainer = () => {

const div = document.createElement('div');

document.body.appendChild(div);

return div;

};

const SomeComponent = ({ getContainer = defaultGetContainer }) => (

);

React 18 Concurrent Mode

In React 18, effects may fire multiple times. In order to prevent inadvertently breaking the developer's behavior, it has also been adjusted accordingly under StrictMode:

React mounts the component.
- Layout effects are created.
- Effect effects are created.
React simulates effects being destroyed on a mounted component.
- Layout effects are destroyed.
- Effects are destroyed.
React simulates effects being re-created on a mounted component.
- Layout effects are created
- Effect setup code runs

The simple understanding is that under StrictMode, even if your deps contains empty objects, the effect will still be triggered multiple times. When switching to React 18 StrictMode, we will find that there will be a pair of mount nodes in the HTML, and the previous one is empty:

<body>
  <div id="root">...</div>

  <!-- Empty -->
  <div className="sample-holder"></div>

  <!-- Real in use -->
  <div className="sample-holder">
    <div className="ant-component-wrapper">...</div>
  </div>
</body>

Therefore, we adjusted the call implementation, and the default getContainer is also managed through state to ensure that the nodes generated by the previous effect will be cleaned up in StrictMode:

// Fake Code. Just for Demo
const SomeComponent = ({ getContainer }) => {
  const [myContainer, setMyContainer] = React.useState<HTMLElement | null>(null);

  React.useEffect(() => {
    if (getContainer) {
      setMyContainer(getContainer());
      return;
    }

    const div = document.createElement('div');
    document.body.appendChild(div);
    setMyContainer(div);

    return () => {
      document.body.removeChild(div);
    };
  }, [getContainer]);

  return <PopupWrapper getContainer={() => myContainer} />;
};

After putting getContainer into effect management, we can manage nodes in a way that is more in line with the React life cycle, and we can also clean up when getContainer changes. So as to support the scenario of dynamically changing getContainer (although I personally doubt the universality of this usage scenario).

Finally

Due to the fix that getContainer does not support dynamic changes, it also introduces a potential breaking change at the same time. If the developer customizes getContainer to create a new dom node every time, it will cause an infinite loop because of the continuous execution of the effect, resulting in the continuous creation of nodes. If you use this method and encounter problems, you need to pay attention to check.